[lkml]   [2006]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [BUG] dmsetup table output changed from 2.6.18 to 2.6.19-rc3 and breaks yaird.
    On Mon, Oct 30, 2006 at 08:39:08PM +0100, Christophe Saout wrote:
    > > Herbert, the breakage _seems_ to be due to the STATUSTYPE_TABLE case
    > > change:
    > >
    > > - cipher = crypto_tfm_alg_name(cc->tfm);
    > > + cipher = crypto_blkcipher_name(cc->tfm);
    > >
    > > which effectively changes "aes" into "cbc(aes)", which is wrong, since we
    > > show the chainmode separately.

    Yes that's wrong.

    However, the bigger problem is that dmcrypt's algorithm specification
    does not allow all algorithms to be specified. In particular, algorithms
    with dashes in their names cannot be represented in an unambiguous way.

    The separation of chain modes and algorithm names is in fact unnecessary
    and only complicates matters.

    For now it's no big deal since the algorithms people actually use
    can be represented. But it would be nice to get this fixed.

    > ----
    > Fix dm-crypt after the block cipher API changes to correctly return the
    > backwards compatible cipher-chainmode[-ivmode] format for "dmsetup
    > table".
    > Signed-off-by: Christophe Saout <>

    Looks good to me.

    Acked-by: Herbert Xu <>

    Visit Openswan at
    Email: Herbert Xu ~{PmV>HI~} <>
    Home Page:
    PGP Key:
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2006-10-31 01:59    [W:0.023 / U:27.408 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site