lkml.org 
[lkml]   [2006]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 07/11] uml ubd driver: reformat ubd_config
On Sun, Oct 29, 2006 at 08:20:41PM +0100, Paolo 'Blaisorblade' Giarrusso wrote:
> From: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>

> - return(1);
> + ret = 1;
> + goto out;

> +out:
> + return ret;

I think the original form should stay, except for the CodingStyle fix.
As Al once pointed out, 'goto out; ... out: return' is spelled
'return'. If you have no cleanup to do before returning, you might as
well just return.

> + if (n == -1) {
> + ret = 0;
> + goto out;
> }
> - if(n == -1) return(0);

The comment should have noted the bug fix present here.

Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-30 20:31    [W:0.192 / U:0.524 seconds]
©2003-2014 Jasper Spaans. Advertise on this site