lkml.org 
[lkml]   [2006]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: 2.6.19-rc3-git7: scsi_device_unbusy: inconsistent lock state

    * Arjan van de Ven <arjan@infradead.org> wrote:

    > > struct rb_node *parent;
    > > struct cfq_io_context *__cic;
    > > + unsigned long flags;
    > > void *k;
    > >
    > > cic->ioc = ioc;
    > > @@ -1384,9 +1385,9 @@ restart:
    > > rb_link_node(&cic->rb_node, parent, p);
    > > rb_insert_color(&cic->rb_node, &ioc->cic_root);
    > >
    > > - spin_lock_irq(cfqd->queue->queue_lock);
    > > + spin_lock_irqsave(cfqd->queue->queue_lock, flags);
    > > list_add(&cic->queue_list, &cfqd->cic_list);
    > > - spin_unlock_irq(cfqd->queue->queue_lock);
    > > + spin_unlock_irqrestore(cfqd->queue->queue_lock, flags);
    > > }
    >
    > this looks entirely reasonable and correct
    >
    > Acked-By: Arjan van de Ven <arjan@linux.intel.com>

    yep.

    Acked-by: Ingo Molnar <mingo@elte.hu>

    Ingo
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-10-30 19:01    [W:0.022 / U:30.896 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site