lkml.org 
[lkml]   [2006]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] Fix WARN_ON / WARN_ON_ONCE regression
    From
    Date
    On Tue, 2006-10-03 at 17:07 -0700, Andrew Morton wrote:

    >
    > Perhaps the `static int __warn_once' is getting put in the same cacheline
    > as some frequently-modified thing. Perhaps try marking that as __read_mostly?
    >

    I've tried marking static int __warn_once as __read_mostly. However, it
    did not help with reducing the cache miss :(

    So I would suggest reversing the "Let WARN_ON/WARN_ON_ONCE return the
    condition" patch. It has just been added 3 days ago so reversing it
    should not be a problem.

    Tim
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-10-04 03:01    [W:0.024 / U:0.328 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site