Messages in this thread | | | Date | Tue, 3 Oct 2006 07:48:22 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH/RFC] Math-emu kills the kernel on Athlon64 X2 II -- it's terminally broken |
| |
On Tue, 3 Oct 2006, Andi Kleen wrote: > > Actually I looked at the code more closely. It looks like kernel math > emulation is much more broken. e.g. kernel_fpu_begin() is missing > code and lots of other paths in i387 that need to check HAVE_HWFP don't.
No it's not.
kernel_fpu_begin() has the _one_ test that matters:
if (thread->status & TS_USEDFPU) {
since if software emulation is on, nobody will ever have the TS_USEDFPU flag set.
> Fixing it properly would be much more work.
No. It's all fixed properly already.
The bug is simply on the newer FXSR paths - marking the FPU emulation broken is just stupid.
Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |