Messages in this thread | | | Subject | Re: [PATCH v2] Re: Battery class driver. | From | David Woodhouse <> | Date | Sat, 28 Oct 2006 15:36:33 +0100 |
| |
On Sat, 2006-10-28 at 16:34 +0200, Shem Multinymous wrote: > * Thou shalt not export any attributes in sysfs except these, and > with these units: */ > > Drivers *will* want to violate this. For example, the "inhibit > charging for N minutes" command on ThinkPads seems too arcane to be > worthy of generalization. I would add a more sensible boolean > "charging_inhibit" attribute to battery.h, and let the ThinkPad driver > implement it as well as it can. The driver will then expose a > non-stadard "charging_inhibit_minutes" attribute to reveal the finer > level of access to those who care.
If it makes enough sense that it's worth exporting it to userspace at all, then it can go into battery.h.
-- dwmw2
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |