lkml.org 
[lkml]   [2006]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [take21 2/4] kevent: poll/select() notifications.
On Sat, Oct 28, 2006 at 12:04:10PM +0200, Eric Dumazet (dada1@cosmosbay.com) wrote:
> Evgeniy Polyakov a écrit :
>
> >+ file = fget(k->event.id.raw[0]);
> >+ if (!file)
> >+ return -ENODEV;
>
> Please, do us a favor, and use EBADF instead of ENODEV.
>
> EBADF : /* Bad file number */
>
> ENODEV : /* No such device */
>
> You have many ENODEV uses in your patches and that really hurts.

Ok :)

> Eric

--
Evgeniy Polyakov
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-28 12:11    [W:0.243 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site