Messages in this thread | | | Date | Sat, 28 Oct 2006 14:08:15 +0400 | From | Evgeniy Polyakov <> | Subject | Re: [take21 2/4] kevent: poll/select() notifications. |
| |
On Sat, Oct 28, 2006 at 12:04:10PM +0200, Eric Dumazet (dada1@cosmosbay.com) wrote: > Evgeniy Polyakov a écrit : > > >+ file = fget(k->event.id.raw[0]); > >+ if (!file) > >+ return -ENODEV; > > Please, do us a favor, and use EBADF instead of ENODEV. > > EBADF : /* Bad file number */ > > ENODEV : /* No such device */ > > You have many ENODEV uses in your patches and that really hurts.
Ok :)
> Eric
-- Evgeniy Polyakov - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |