lkml.org 
[lkml]   [2006]   [Oct]   [28]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateSat, 28 Oct 2006 12:04:10 +0200
FromEric Dumazet <>
SubjectRe: [take21 2/4] kevent: poll/select() notifications.
Evgeniy Polyakov a écrit :

> +	file = fget(k->event.id.raw[0]);
> +	if (!file)
> +		return -ENODEV;

Please, do us a favor, and use EBADF instead of ENODEV.

EBADF : /* Bad file number */
ENODEV : /* No such device */
You have many ENODEV uses in your patches and that really hurts.

Eric

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-28 10:07    [W:6.134 / U:0.010 seconds]
©2003-2008 Jasper Spaans