Messages in this thread | | | From | David Howells <> | Subject | Re: [Q] missing unused dentry in prune_dcache()? | Date | Thu, 26 Oct 2006 15:07:32 +0100 |
| |
Vasily Averin <vvs@sw.ru> wrote:
> I would note that in first two hunks you have decremented > dentry_stat.nr_unused correctly, under dcache_lock. Probably it's better to > count freed dentries only in third case and corrects dentry_stat.nr_unused > value inside shrink_dcache_for_umount_subtree() function before return.
Maybe, maybe not. This way we only touch the dentry_stat cacheline once, if at all. I'm not sure it'd make much difference though.
David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |