Messages in this thread Patch in this message | | | Date | Tue, 24 Oct 2006 20:46:31 -0700 | From | "Yinghai Lu" <> | Subject | Re: [PATCH] x86_64 irq: reset more to default when clear irq_vector for destroy_irq |
| |
resend with gmail.
Clear the irq releated entries in irq_vector, irq_domain and vector_irq instead of clearing irq_vector only. So when new irq is created, it could reuse that vector. (actually is the second loop scanning from FIRST_DEVICE_VECTOR+8). This could avoid the vectors are used up with enough module inserting and removing
Cc: Eric W. Biedierman <ebiederm@xmission.com> Signed-off-By: Yinghai Lu <yinghai.lu@amd.com> --- linux-2.6/arch/x86_64/kernel/io_apic.c 2006-10-24 13:40:48.000000000 -0700 +++ linux-2.6.xx/arch/x86_64/kernel/io_apic.c 2006-10-24 14:03:08.000000000 -0700 @@ -716,6 +716,22 @@ return vector; } +static void __clear_irq_vector(int irq) +{ + int old_vector = -1; + if (irq_vector[irq] > 0) + old_vector = irq_vector[irq]; + if (old_vector >= 0) { + cpumask_t old_mask; + int old_cpu; + cpus_and(old_mask, irq_domain[irq], cpu_online_map); + for_each_cpu_mask(old_cpu, old_mask) + per_cpu(vector_irq, old_cpu)[old_vector] = -1; + } + irq_vector[irq] = 0; + irq_domain[irq] = CPU_MASK_NONE; +} + void __setup_vector_irq(int cpu) { /* Initialize vector_irq on a new cpu */ @@ -1803,7 +1819,7 @@ dynamic_irq_cleanup(irq); spin_lock_irqsave(&vector_lock, flags); - irq_vector[irq] = 0; + __clear_irq_vector(irq); spin_unlock_irqrestore(&vector_lock, flags); } | |