lkml.org 
[lkml]   [2006]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 8/13] KVM: vcpu execution loop
    On 10/23/06, Avi Kivity <avi@qumranet.com> wrote:
    > Arnd Bergmann wrote:
    > > On Monday 23 October 2006 22:16, Avi Kivity wrote:
    > >
    > >>> This looks like you should simply put it into a .S file.
    > >>>
    > >>>
    > >>>
    > >> Then I lose all the offsetof constants down the line. Sure, I could do
    > >> the asm-offsets dance but it seems to me like needless obfuscation.
    > >>
    > >
    > > Ok, I see.
    > >
    > > How if you pass &vcpu->regs and &vcpu->cr2 to the functions instead of
    > > kvm_vcpu?
    > >
    > >
    >
    > I could do that, but I feel that's more brittle. I might need more (or
    > other) fields later on. It will also cost me more pushes on the stack
    > (no real performance or space impact, just C64-era frugality).

    maybe thats the mindsent needed to make these virtual cpu patches
    without eating away all the cpu power with more than needed
    abstractions ;)

    --
    Greetz, Antonio Vargas aka winden of network

    http://network.amigascne.org/
    windNOenSPAMntw@gmail.com
    thesameasabove@amigascne.org

    Every day, every year
    you have to work
    you have to study
    you have to scene.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-10-23 23:05    [W:0.022 / U:60.220 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site