Messages in this thread | | | Subject | RE: [PATCH] x86_64 irq: reuse vector for set_xxx_irq_affinity in phys flat mode | Date | Mon, 23 Oct 2006 13:00:23 -0700 | From | "Lu, Yinghai" <> |
| |
From: ebiederm@xmission.com [mailto:ebiederm@xmission.com]
>Beyond that I have a few nits to pick with the patch. >- We duplicate the code that claims a new vector which makes > maintenance a pain. >- The comments are specific to phys_flat but the code is not. >- The test for being able to use the old_vector in the new domain > should be: ...[old_vector] == vector || ...[old_vector] == -1
Please attached one. This one need to after your patch about irq.
YH
[unhandled content-type:application/octet-stream] | |