lkml.org 
[lkml]   [2006]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [patches] Re: [PATCH] [14/19] i386: Disable nmi watchdog on all ThinkPads
Date

> > - if (nmi_watchdog == NMI_DEFAULT && dmi_get_year(DMI_BIOS_DATE) >= 2004)
> > + Probably safe on most older systems too, but let's be careful.
> > + IBM ThinkPads use INT10 inside SMM and that allows early NMI inside SMM
> > + which hangs the system. Disable watchdog for all thinkpads */
> > + if (nmi_watchdog == NMI_DEFAULT && dmi_get_year(DMI_BIOS_DATE) >= 2004 &&
> > + !dmi_name_in_vendors("ThinkPad"))
> > nmi_watchdog = NMI_LOCAL_APIC;
>
> This is going to get some people scratching their heads wondering
> why it isn't working if they ever try nmi_watchdog on one of these.
> How about adding an explanitory printk ?

When you enable it manually then NMI_DEFAULT won't be set and this code
is never executed.

BTW their machines will likely not stay up long enough that they can
see the printk (unless Lenovo fixes that particular bug in the future,
they are aware of it)

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-21 20:15    [W:1.558 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site