lkml.org 
[lkml]   [2006]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Date
Subject[PATCH] cpuset: mempolicy migration typo fix
From: Paul Jackson <pj@sgi.com>

Mistyped an ifdef CONFIG_CPUSETS - fixed.

I doubt that anyone ever noticed. The impact of this typo was
that if someone:
1) was using MPOL_BIND to force off node allocations
2) while using cpusets to constrain memory placement
3) when that cpuset was migrating that jobs memory
4) while the tasks in that job were actively forking
then there was a rare chance that future allocations using
that MPOL_BIND policy would be node local, not off node.

Signed-off-by: Paul Jackson <pj@sgi.com>

---
It builds under my cross tool setup, it runs my usual
cpuset tests and it runs my not particularly elaborate
cpuset memory migration test.

include/linux/mempolicy.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- 2.6.19-rc2-mm1.orig/include/linux/mempolicy.h 2006-10-19 23:08:11.396940924 -0700
+++ 2.6.19-rc2-mm1/include/linux/mempolicy.h 2006-10-19 23:26:03.703107004 -0700
@@ -150,7 +150,7 @@ extern void mpol_rebind_mm(struct mm_str
extern void mpol_fix_fork_child_flag(struct task_struct *p);
#define set_cpuset_being_rebound(x) (cpuset_being_rebound = (x))

-#ifdef CONFIG_CPUSET
+#ifdef CONFIG_CPUSETS
#define current_cpuset_is_being_rebound() \
(cpuset_being_rebound == current->cpuset)
#else
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-20 09:45    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site