Messages in this thread | | | Subject | Re: [PATCH] (update) more helpful WARN_ON and BUG_ON messages | From | Peter Zijlstra <> | Date | Fri, 20 Oct 2006 19:02:26 +0200 |
| |
On Fri, 2006-10-20 at 11:54 -0500, Eric Sandeen wrote: > Eric Sandeen wrote: > > > After a few bugs I encountered in FC6 in buffer.c, with output like: > > > > Kernel BUG at fs/buffer.c: 2791 > > > > where buffer.c contains: > > > > ... > > BUG_ON(!buffer_locked(bh)); > > BUG_ON(!buffer_mapped(bh)); > > BUG_ON(!bh->b_end_io); > > ... > > > > around line 2790, it's awfully tedious to go get the exact failing kernel tree > > just to see -which- BUG_ON was encountered. > > > > Printing out the failing condition as a string would make this more helpful IMHO. > > > > This is mostly just compile-tested... comments? > Whoops, missed WARN_ON_ONCE... thanks Peter. > > Signed-off-by: Eric Sandeen <sandeen@redhat.com> Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
I like this, as you pointed out, its not always obvious which condition is the offending one, this makes it more clear.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |