lkml.org 
[lkml]   [2006]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/3] netpoll: rework skb transmit queue
    On Fri, 20 Oct 2006 12:27:53 -0700 (PDT)
    David Miller <davem@davemloft.net> wrote:

    > From: Stephen Hemminger <shemminger@osdl.org>
    > Date: Fri, 20 Oct 2006 08:40:15 -0700
    >
    > > The only user of the drop hook was netconsole, and I fixed that path.
    > > This probably breaks netdump, but that is out of tree, so it needs
    > > to fix itself.
    >
    > I believe that netdump needs to requeue things because dropping the
    > packet is simply not allowed, and the ->drop callback gives the
    > netdump code a way to handle things without actually dropping the
    > packet. If that's true, you can't just free the SKB on it.
    >
    > Are you sure your new TX strategy can avoid such drops properly?

    Yes, it has a queue. if it can't send it waits and retries.

    >
    > Please take a quick peek at the netdump code, it's available, and make
    > some reasonable effort to determine whether it can still work with
    > your new code.

    Where, I'm not digging in side some RHEL rpm patch pile to find it.

    --
    Stephen Hemminger <shemminger@osdl.org>
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-10-20 21:35    [W:0.023 / U:30.860 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site