lkml.org 
[lkml]   [2006]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: kernel BUG in __cache_alloc_node at linux-2.6.git/mm/slab.c:3177!
    On Fri, 20 Oct 2006 17:00:34 +0100
    Andy Whitcroft <apw@shadowen.org> wrote:

    > > I'll follow up to this email with the reversion patch we used in
    > > testing. It seems to sort this problem out at least, though now its
    > > blam'ing in ibmveth, so am retesting with yet another patch. This patch
    > > reverts the two patches above and updates the commentry on the Kconfig
    > > entry.
    >
    > Ok, I've just gotten a successful boot on this box for the first time in
    > like 15 git releases. I needed the three patches below:
    >
    > clameter-fallback_alloc_fix2 -- from earlier in this thread, under the
    > message ID below:
    > <Pine.LNX.4.64.0610131515200.28279@schroedinger.engr.sgi.com>

    That's this:

    Here is another fall back fix checking if the slab has already been setup
    for this node. MPOL_INTERLEAVE could redirect the allocation.

    Index: linux-2.6.19-rc1-mm1/mm/slab.c
    ===================================================================
    --- linux-2.6.19-rc1-mm1.orig/mm/slab.c 2006-10-10 21:47:12.949563383 -0500
    +++ linux-2.6.19-rc1-mm1/mm/slab.c 2006-10-13 17:21:31.937863714 -0500
    @@ -3158,12 +3158,15 @@ void *fallback_alloc(struct kmem_cache *
    struct zone **z;
    void *obj = NULL;

    - for (z = zonelist->zones; *z && !obj; z++)
    + for (z = zonelist->zones; *z && !obj; z++) {
    + int nid = zone_to_nid(*z);
    +
    if (zone_idx(*z) <= ZONE_NORMAL &&
    - cpuset_zone_allowed(*z, flags))
    + cpuset_zone_allowed(*z, flags) &&
    + cache->nodelists[nid])
    obj = __cache_alloc_node(cache,
    - flags | __GFP_THISNODE,
    - zone_to_nid(*z));
    + flags | __GFP_THISNODE, nid);
    + }
    return obj;
    }

    Christoph, can you please finalise and resend that?

    > Reintroduce-NODES_SPAN_OTHER_NODES-for-powerpc -- the patch I just
    > submitted, under the message ID below:
    > <8a76dfd735e544016c5f04c98617b87d@pinky>

    OK, I got that.

    > ibmveth-fix-index-increment-calculation -- this patch is already in -mm.

    Normally a Jeff thing, but small-and-simple. I'll send that in to Linus
    today.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-10-20 19:17    [W:0.026 / U:30.760 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site