lkml.org 
[lkml]   [2006]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [RFC PATCH] move drm to pci_request_irq
    On Mon, Oct 02, 2006 at 08:12:29PM +0000, Frederik Deweerdt wrote:
    >
    > + pci_set_drvdata(dev, NULL);
    > +
    > DRM_DEBUG("lastclose completed\n");

    Not necessary. pci_devs are allocated initialised to 0.

    > @@ -132,8 +132,10 @@ static int drm_irq_install(drm_device_t
    > if (drm_core_check_feature(dev, DRIVER_IRQ_SHARED))
    > sh_flags = IRQF_SHARED;
    >
    > - ret = request_irq(dev->irq, dev->driver->irq_handler,
    > - sh_flags, dev->devname, dev);
    > + pci_set_drvdata(dev->pdev, dev);
    > +
    > + ret = pci_request_irq(dev->pdev, dev->driver->irq_handler,
    > + sh_flags, dev->devname);

    This seems like the wrong place to be setting the pci_drvdata. It
    should probably be done in each driver. But then, requesting the IRQ
    should also be done by each driver. You've dragged us into the "wow,
    what a mess DRI is" black hole here, I'm afraid.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-10-02 20:41    [W:0.022 / U:30.768 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site