Messages in this thread Patch in this message | | | Date | Mon, 2 Oct 2006 12:27:44 -0600 | From | Matthew Wilcox <> | Subject | Re: [RFC PATCH] move aic7xxx to pci_request_irq |
| |
On Mon, Oct 02, 2006 at 08:07:03PM +0000, Frederik Deweerdt wrote: > +++ b/drivers/scsi/aic7xxx/aic79xx_osm_pci.c > @@ -341,12 +341,12 @@ ahd_pci_map_int(struct ahd_softc *ahd) > { > int error; > > - error = request_irq(ahd->dev_softc->irq, ahd_linux_isr, > - IRQF_SHARED, "aic79xx", ahd); > + error = pci_request_irq(ahd->dev_softc, ahd_linux_isr, > + IRQF_SHARED, "aic79xx"); > if (!error) > ahd->platform_data->irq = ahd->dev_softc->irq; > > - return (-error); > + return error;
Seems unsafe to me. Unless you want to trace through the whole driver changing its internal conventions to use negative errnos like the rest of the kernel.
> - > - return (-error); > -} > > + return error; > +}
Ditto. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |