Messages in this thread Patch in this message |  | | | From | Trond Myklebust <> | | Date | Thu, 19 Oct 2006 13:04:32 -0400 | | Subject | [PATCH 08/11] NFS: __nfs_revalidate_inode() can use "inode" before checking it is non-NULL |
| |
From: Chuck Lever <chuck.lever@oracle.com>
The "!inode" check in __nfs_revalidate_inode() occurs well after the first time it is dereferenced, so get rid of it.
Coverity: #cid 1372, 1373
Test plan: Code review; recheck with Coverity.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> --- fs/nfs/inode.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c index 9979ad1..08cc4c5 100644 --- a/fs/nfs/inode.c +++ b/fs/nfs/inode.c @@ -583,7 +583,7 @@ __nfs_revalidate_inode(struct nfs_server nfs_inc_stats(inode, NFSIOS_INODEREVALIDATE); lock_kernel(); - if (!inode || is_bad_inode(inode)) + if (is_bad_inode(inode)) goto out_nowait; if (NFS_STALE(inode)) goto out_nowait; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |