lkml.org 
[lkml]   [2006]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: fsstack: struct path
On Wed, 18 Oct 2006 10:06:23 +0100
Al Viro <viro@ftp.linux.org.uk> wrote:

> On Wed, Oct 18, 2006 at 01:35:51AM -0700, Andrew Morton wrote:
> > On Wed, 18 Oct 2006 01:31:03 -0700
> > Andrew Morton <akpm@osdl.org> wrote:
> >
> > > > One, rather unfortunate, fact is that struct path is also defined in
> > > > include/linux/reiserfs_fs.h as something completely different - reiserfs
> > > > specific.
> > > >
> > > > Any thoughts?
> > > >
> > >
> > > reiserfs is being bad. s/path/reiserfs_path/g
> >
> > There's also drivers/md/dm-mpath.h's struct path. Renaming fs/namei.c's
> > `struct path' to `struct namei_path' would be prudent.
>
> Yuck... If we really want to switch to it (and I can give you a dozen
> examples of possible users right now - starting with struct file), putting
> namei_ into it is both uninformative and ugly.
>
> I'm not sure what would be the good name here; "pathname" comes to mind,
> but it suggests that we are dealing with a string. And "location" is
> too vague (and probably would cause fsckloads of conflicts itself).
>
> Suggestions? "pathname" would almost work; the difference is that this
> is not a string but a node in tree that string resolves to.

path_item?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-18 11:15    [W:0.216 / U:0.448 seconds]
©2003-2014 Jasper Spaans. Advertise on this site