lkml.org 
[lkml]   [2006]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -rt] powerpc update

* Daniel Walker <dwalker@mvista.com> wrote:

> Pay close attention to the fasteoi interrupt threading. I added usage
> of mask/unmask instead of using level handling, which worked well on
> PPC.

this is wrong - it should be doing mask+ack.

also note that you changed:

> - goto out_unlock;

to:

> + goto out;

and you even tried to hide your tracks:

> out:
> desc->chip->eoi(irq);
> -out_unlock:
> spin_unlock(&desc->lock);

:-)

really, the ->eoi() op should only be called for true fasteoi cases.
What we want here is to turn the fasteoi handler into a handler that
does mask+ack and then unmask. Not 'mask+eoi ... unmask' as your patch
does.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-18 09:39    [W:0.081 / U:0.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site