lkml.org 
[lkml]   [2006]   [Oct]   [18]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateWed, 18 Oct 2006 07:55:42 +0200
FromIngo Molnar <>
SubjectRe: [PATCH] Fix generic WARN_ON message
* Jeremy Fitzhardinge <jeremy@goop.org> wrote:

> A warning is a warning, not a BUG.

> -		printk("BUG: warning at %s:%d/%s()\n", __FILE__,	\
> +		printk("WARNING at %s:%d %s()\n", __FILE__,	\

i'm not really happy about this change.

Firstly, most WARN_ON()s are /bugs/, not warnings ... If it's a real 
warning, a KERN_INFO printk should be done.

Secondly, the reason i changed it to the 'BUG: ...' format is that i 
tried to make it easier for automated tools (and for users) to figure 
out that a kernel bug happened.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-18 06:07    [W:0.414 / U:0.110 seconds]
©2003-2008 Jasper Spaans