Messages in this thread | | | Date | Wed, 18 Oct 2006 16:55:05 +0200 | Subject | Re: [PATCH 2.6.19-rc1 full] drivers: add LCD support | From | Franck Bui-Huu <> |
| |
Hi
Miguel Ojeda Sandonis wrote: > Andrew, here it is the complete patch again as you requested. >
sorry for coming lately, I just noticed your patch in -mm tree.
Did you took a look at drivers/video/arcfb.c driver ? It seems to be a fb driver for ks108 lcd controller. A lot of code is related to the platform though and the controller is driven through GPIO but have you tried to split the code for sharing controller specific code. Note, I don't say it's a good idea, it's just a question that comes in mind.
Also you create driver/auxdisplay directory whereas drivers such the one I mentioned previously is located in drivers/video. Why not putting your driver in driver/video ?
Franck - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |