Messages in this thread | | | Date | 18 Oct 2006 13:15:46 +0200 | Date | Wed, 18 Oct 2006 13:15:46 +0200 | From | Andi Kleen <> | Subject | Re: [PATCH 2.6.19-rc2-mm1] Fix fake return address |
| |
On Tue, Oct 17, 2006 at 07:21:38PM -0700, Jeremy Fitzhardinge wrote: > The fake return address was being set to __KERNEL_PDA, rather than 0. > Push it earlier while %eax still equals 0.
Oops. That might explain some of the unwind problems. Thanks.
-Andi
> > Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com> > Cc: Andi Kleen <ak@muc.de> > Cc: Andrew Morton <akpm@osdl.org> > > diff -r b8e58159855c arch/i386/kernel/head.S > --- a/arch/i386/kernel/head.S Tue Oct 17 19:04:59 2006 -0700 > +++ b/arch/i386/kernel/head.S Tue Oct 17 19:05:46 2006 -0700 > @@ -316,12 +316,12 @@ 1: movl $(__KERNEL_DS),%eax # reload all > xorl %eax,%eax # Clear FS and LDT > movl %eax,%fs > lldt %ax > + pushl %eax # fake return address > > movl $(__KERNEL_PDA),%eax > mov %eax,%gs > > cld # gcc2 wants the direction flag cleared at > all times > - pushl %eax # fake return address > #ifdef CONFIG_SMP > movb ready, %cl > movb $1, ready > > > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |