[lkml]   [2006]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [patch 1/1] watchdog driver for Digital-Logic MSM-P5XEN PC104 unit
Ar Maw, 2006-10-17 am 12:34 +0000, ysgrifennodd
> +static void
> +wdt_enable(unsigned long data)
> +{
> + (void)data;
> +
> + outb(inb(io_base + WDT_OFFSET) & 0xf7, io_base + WDT_OFFSET);
> +}
> +

If you don't need "data" why pass it ?

No locking against parallel close/open
No no-way-out lock implementation
Short many of the standard ioctls it could and should implement (eg
timeout get)

NAK for now although it just needs tidying and expanding out a little to
be a good driver.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2006-10-17 15:15    [W:0.086 / U:8.288 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site