Messages in this thread | | | Subject | Re: [PATCH] libsas: support NCQ for SATA disks | From | James Bottomley <> | Date | Tue, 17 Oct 2006 11:35:37 -0500 |
| |
On Tue, 2006-10-17 at 07:15 -0400, Jeff Garzik wrote: > Brian King wrote: > > This doesn't look like the right fix for the oops you were seeing. The > > SAS usage of libata has ap->scsi_host as NULL, which indicates that > > libata does not own the associated scsi_host. I'm concerned you may > > have broken some other code path by making this change. I think the correct > > fix may require removing the dependence of ap->scsi_host from > > ata_dev_config_ncq. > > Yep. I had already mentioned this on IRC.
I understand, but right at the moment, my priority is sorting out the aic94xx driver so that it works with SATA devices. It has become apparent that there's some need for a bit of code sorting out in libata to drive intelligent sas controllers, so we can take a look at bugs in ata_dev_config_ncq() when someone's time frees up to look into the libata issues.
James
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |