Messages in this thread | | | Subject | Re: [RFC][PATCH] ->signal->tty locking | From | Alan Cox <> | Date | Tue, 17 Oct 2006 15:08:03 +0100 |
| |
Ar Maw, 2006-10-17 am 15:00 +0200, ysgrifennodd Peter Zijlstra: > How about something like this; I'm still shaky on the lifetime rules of > tty objects, I'm about to add a refcount and spinlock/mutex to > tty_struct, this is madness....
It has two already.
I wouldn't worry about being shaky about the lifetime rules, thats a forensics job at the moment.
> + tty = current_get_tty();
Sensible way to go whichever path we use and once it returns a refcount bumped object in future it'll clean up a lot more. get_current_tty or just current_tty() would fit the naming in the kernel better
I agree entirely with the path this patch is taking.
Alan
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |