lkml.org 
[lkml]   [2006]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] cpu topology: consider sysfs_create_group return value
On Mon, 16 Oct 2006 09:31:26 +0200,
Heiko Carstens <heiko.carstens@de.ibm.com> wrote:

> From: Heiko Carstens <heiko.carstens@de.ibm.com>
>
> [patch] cpu topology: consider sysfs_create_group return value.
>
> Take return value of sysfs_create_group() into account. That function got
> called in case of CPU_ONLINE notification. Since callbacks are not allowed
> to fail on CPU_ONLINE notification do the sysfs group creation on
> CPU_UP_PREPARE notification.
> Also remember if creation succeeded in a bitmask. So it's possible to know
> wether it's legal to call sysfs_remove_group or not.
>
> In addition some other minor stuff:
>
> - since CPU_UP_PREPARE might fail add CPU_UP_CANCELED handling as well.
> - use hotcpu_notifier instead of register_hotcpu_notifier.
> - #ifdef code that isn't needed in the !CONFIG_HOTPLUG_CPU case.
>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> ---
>
> drivers/base/topology.c | 56 +++++++++++++++++++++++++++---------------------
> 1 file changed, 32 insertions(+), 24 deletions(-)

Looks good.

Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-16 10:57    [W:0.026 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site