lkml.org 
[lkml]   [2006]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/5] Allow more than PAGESIZE data read in configfs
    On Mon, Oct 16, 2006 at 12:24:35PM -0700, Chandra Seetharaman wrote:
    > On Sat, 2006-10-14 at 13:10 -0700, Joel Becker wrote:
    > > Issues of PAGE_SIZE and attribute size aside, the patch posted
    > > was incorrect. While they used seq_file, they implemented it in a
    >
    > I do not think it is incorrect. It provides a simplest interface to
    > configfs's clients.

    I understand that it provides a simple sed(1)-based change for
    existing clients. However, it abuses seq_file in exactly the wrong way.

    > > completely inefficent fashion, filling the entire buffer in one ->show()
    > > call rather than letting multiple read(2) calls iterate their list.
    >
    > So, are you suggesting that we should provide a generic seq_operations
    > interface to configfs's clients ?

    Yes, if we provide a vector type in any way, it should be via
    seq_operations or something like it. If we're going to use seq_file, we
    should use it correctly.

    Joel

    --

    "What no boss of a programmer can ever understand is that a programmer
    is working when he's staring out of the window"
    - With apologies to Burton Rascoe


    Joel Becker
    Principal Software Developer
    Oracle
    E-mail: joel.becker@oracle.com
    Phone: (650) 506-8127
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-10-17 01:13    [from the cache]
    ©2003-2014 Jasper Spaans. Advertise on this site