Messages in this thread Patches in this message |  | | | Date | Mon, 16 Oct 2006 08:26:08 -0700 | | From | "Yinghai Lu" <> | | Subject | Fwd: [PATCH] x86_64: typo in __assign_irq_vector when update pos for vector and offset |
| |
Please check the patch.
Also I have a question about TARGET_CPUS in io_apic.c.
for a 16 sockets system with 32 non coherent ht chain. and if every chain have 8 irq for devices, the genapic will use physflat. and it should use you new added "different cpu can have same vector for different irq". --- in the i8259.c but the setup_IOAPIC_irqs and arch_setup_ht_irq and arch_setup_msi_irq is still using TARGET_CPUS ( it is cpumask_of_cpu(0) for physflat), so the assign_irq_vector will not get vector for them, becase cpu 0 does not have that much vector to be alllocated. and later setup_affinity_xxx_irq can not be used because before irq is not there and show on /proc/interrupts.
So I want to 1. for arch_setup_ht_irq and arch_setup_msi_irq, we can use the dev it takes to get bus and use bus->sysdata to get bus->node mapping that is created in fillin_cpumask_to_bus, to get real target_cpus instead of cpu0. 2. for ioapics, may need to add another array, ioapic_node[MAX_IOAPICS], and use ioapic address to get the numa node for it. So later can use it to get real targets cpus when need to use TARGET_CPUS.
Please comments.
Thanks
Yinghai Lu
---------- Forwarded message ---------- From: yhlu <yhlu.kernel@gmail.com> Date: Oct 15, 2006 12:21 PM Subject: re: [PATCH] x86_64: typo in __assign_irq_vector when update pos for vector and offset To: "Eric W. Biederman" <ebiederm@xmission.com>, Andi Kleen <ak@muc.de> Cc: linux kernel mailing list <linux-kernel@vger.kernel.org>, yhlu.kernel@gmail.com
Please use this one
typo with cpu instead of new_cpu
Signed-off-by: Yinghai Lu <yinghai.lu@amd.com>
diff --git a/arch/x86_64/kernel/io_apic.c b/arch/x86_64/kernel/io_apic.c index 44b55f8..756d097 100644 --- a/arch/x86_64/kernel/io_apic.c +++ b/arch/x86_64/kernel/io_apic.c @@ -651,12 +651,12 @@ next: if (vector == IA32_SYSCALL_VECTOR) goto next; for_each_cpu_mask(new_cpu, domain) - if (per_cpu(vector_irq, cpu)[vector] != -1) + if (per_cpu(vector_irq, new_cpu)[vector] != -1) goto next; /* Found one! */ for_each_cpu_mask(new_cpu, domain) { - pos[cpu].vector = vector; - pos[cpu].offset = offset; + pos[new_cpu].vector = vector; + pos[new_cpu].offset = offset; } if (old_vector >= 0) { int old_cpu;diff --git a/arch/x86_64/kernel/io_apic.c b/arch/x86_64/kernel/io_apic.c index 44b55f8..756d097 100644 --- a/arch/x86_64/kernel/io_apic.c +++ b/arch/x86_64/kernel/io_apic.c @@ -651,12 +651,12 @@ next: if (vector == IA32_SYSCALL_VECTOR) goto next; for_each_cpu_mask(new_cpu, domain) - if (per_cpu(vector_irq, cpu)[vector] != -1) + if (per_cpu(vector_irq, new_cpu)[vector] != -1) goto next; /* Found one! */ for_each_cpu_mask(new_cpu, domain) { - pos[cpu].vector = vector; - pos[cpu].offset = offset; + pos[new_cpu].vector = vector; + pos[new_cpu].offset = offset; } if (old_vector >= 0) { int old_cpu; |  |