Messages in this thread |  | | | Date | Mon, 16 Oct 2006 17:26:31 +0200 | | From | Cornelia Huck <> | | Subject | Re: [Patch 3/3] Driver core: Per-subsystem multithreaded probing. |
| |
On Mon, 16 Oct 2006 10:59:28 -0400 (EDT), Alan Stern <stern@rowland.harvard.edu> wrote:
> That's not quite true. You could acquire dev->parent->sem always, just to > be certain.
But dev->parent->sem wouldn't be taken in the non-multithreaded path, so we would change the semantics.
> However USB shouldn't use this form of multithreaded probing > in any case; it should instead use multiple threads for khubd.
OK, so usb shouldn't request multithreaded probe.
> > but > > that still results in bus->remove being called without a prior ->probe > > (but not drv->probe since dev->driver is not set at that time). > > How so? We shouldn't call bus->remove if a driver isn't bound.
Eh, yes. I was confused :)
> Some other things were left out of the patch. Since we can no longer know > whether any drivers will get bound at all, device_attach() should now > return void.
But device_bind_driver() may still return an error, if creating the links failed.
-- Cornelia Huck Linux for zSeries Developer Tel.: +49-7031-16-4837, Mail: cornelia.huck@de.ibm.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |