Messages in this thread | | | Date | Sat, 14 Oct 2006 10:26:08 +0200 | From | Pavel Machek <> | Subject | HP disk protection Re: Remn Yan <> ha scritto: |
| |
On Fri 2006-10-13 20:32:48, Burman Yan wrote: > >From: Luca Tettamanti <kronos.it@gmail.com>
> >Burman Yan <yan_952@hotmail.com> ha scritto: > >> I would like to hear your remarks on this version. > > > >> +static ssize_t mdps_calibrate_store(struct device *dev, > >> + struct device_attribute *attr, const char *buf, > >size_t count) > >> +{ > >> + mdps_calibrate_mouse(); > >> + return count; > >> +} > > > >No locking here? > > I don't want to lock it here, since the mouse polling kthread is heavy as > it is.
> I'd rather report a wrong value of mouse position while recalibrating. > The way I see it, if you're recalibrating your mouse, chances are you're > not playing at the same precise millisecond. In my opinion it's worth more > battery life.
Hmm, and are you sure it can't oops or something? Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |