lkml.org 
[lkml]   [2006]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/1] Char: correct pci_get_device changes
From
Date
Ar Sul, 2006-10-15 am 01:36 +0200, ysgrifennodd Jiri Slaby:
> correct pci_get_device changes
>
> Commits 881a8c120acf7ec09c90289e2996b7c70f51e996 and
> efe1ec27837d6639eae82e1f5876910ba6433c3f are totally wrong and

No I disagree, they are totally right. They stop crashes walking the
list during a hotplug of another card. If you hotplug the moxa or rio
card you are screwed. Your patches solve a different problem to the ones
the pci_dev_get changes solve.

Your changes also minimally handle the hotplug of the moxa or rio card
which I guess could theoretically happen in some weird system and are a
definite improvement.

> It affects moxa and rio char drivers. (All this stuff deserves to be
> converted to pci_probing, though.)

Agreed, or dropped

Acked-by: Alan Cox <alan@redhat.com>


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-15 01:57    [W:0.056 / U:0.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site