lkml.org 
[lkml]   [2006]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/5] Allow more than PAGESIZE data read in configfs
    On Sat, Oct 14, 2006 at 12:43:51PM -0700, Andrew Morton wrote:
    > On Sat, 14 Oct 2006 01:01:07 -0700
    > Greg KH <greg@kroah.com> wrote:
    > > Argh!!!!
    > >
    > > Are you going to honestly tell me you have a single attribute in sysfs
    > > that is larger than PAGE_SIZE?
    >
    > He does not. It's a matter of reusing existing facilities rather than
    > impementing similar things in multiple places. The equivalent patch in
    > configfs removed a decent amount of code:

    Issues of PAGE_SIZE and attribute size aside, the patch posted
    was incorrect. While they used seq_file, they implemented it in a
    completely inefficent fashion, filling the entire buffer in one ->show()
    call rather than letting multiple read(2) calls iterate their list.

    Joel

    --

    "Anything that is too stupid to be spoken is sung."
    - Voltaire

    Joel Becker
    Principal Software Developer
    Oracle
    E-mail: joel.becker@oracle.com
    Phone: (650) 506-8127
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-10-14 22:15    [W:4.491 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site