lkml.org 
[lkml]   [2006]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 07/18] V4L/DVB (4733): Tda10086: fix frontend selection for dvb_attach
On Sat, Oct 14, 2006 at 02:12:11PM -0400, Michael Krufky wrote:
> Adrian Bunk wrote:
> > On Sat, Oct 14, 2006 at 09:00:50AM -0300, mchehab@infradead.org wrote:
> >> From: Michael Krufky <mkrufky@linuxtv.org>
> >>
> >> Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
> >> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
> >> ---
> >>
> >> drivers/media/dvb/frontends/tda10086.h | 9 +++++++++
> >> 1 files changed, 9 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/drivers/media/dvb/frontends/tda10086.h b/drivers/media/dvb/frontends/tda10086.h
> >> index e8061db..18457ad 100644
> >> --- a/drivers/media/dvb/frontends/tda10086.h
> >> +++ b/drivers/media/dvb/frontends/tda10086.h
> >> @@ -35,7 +35,16 @@ struct tda10086_config
> >> u8 invert;
> >> };
> >>
> >> +#if defined(CONFIG_DVB_TDA10086) || defined(CONFIG_DVB_TDA10086_MODULE)
> >> extern struct dvb_frontend* tda10086_attach(const struct tda10086_config* config,
> >> struct i2c_adapter* i2c);
> >> +#else
> >> +static inline struct dvb_frontend* tda10086_attach(const struct tda10086_config* config,
> >> + struct i2c_adapter* i2c)
> >> +{
> >> + printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __FUNCTION__);
> >> + return NULL;
> >> +}
> >> +#endif // CONFIG_DVB_TDA10086
> >
> > As already said:
> > This breaks with CONFIG_VIDEO_SAA7134_DVB=y, CONFIG_DVB_TDA10086=m.
>
> Again, the breakage is from DVB_FE_CUSTOMIZE=Y, not the above ^^.
>
> This patch must be applied.

Again, this patch fixes only part of the problem, and I did already
suggest how to do it properly if it should be done this way.

> -Mike Krufky

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-14 20:37    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site