Messages in this thread | | | Date | Fri, 13 Oct 2006 10:22:57 -0400 | From | Benjamin LaHaise <> | Subject | Re: [patch] clarify AIO_EVENTS_OFFSET constant |
| |
On Thu, Oct 12, 2006 at 05:00:24PM -0700, Chen, Kenneth W wrote: > A clean up patch: I think it is a lot easier to read AIO_EVENTS_OFFSET > as an offset because of aio_ring at the beginning of a head page, instead > of doing arithmetic of (event on 2nd page - event on 1st page).
Nak. Your change fails if aio_ring is not an exact multiple of the io_event size due to rounding errors, while the original code rounds correctly.
-ben -- "Time is of no importance, Mr. President, only life is important." Don't Email: <dont@kvack.org>. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |