lkml.org 
[lkml]   [2006]   [Oct]   [13]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateFri, 13 Oct 2006 08:30:10 +0100
FromChristoph Hellwig <>
SubjectRe: [PATCH] Readability improvement of open_exec()
> +	if (err)
> +		goto out;
> +
> +	inode = nd.dentry->d_inode;
> +	file = ERR_PTR(-EACCES);
> +	if ((nd.mnt->mnt_flags & MNT_NOEXEC) ||
> +	    !S_ISREG(inode->i_mode))

While you're cleaning up things you can put the whole if statement on
one line, it's less than 80 characters long.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-13 09:35    [from the cache]
©2003-2008