Messages in this thread | | | Date | Wed, 11 Oct 2006 02:12:14 -0700 | From | Joel Becker <> | Subject | Re: [PATCH 2/5] Use seq_file for read side of operations |
| |
On Tue, Oct 10, 2006 at 11:20:55AM -0700, Chandra Seetharaman wrote: > + error = single_open(file, configfs_read_file, buffer); > + if (error) { > + kfree(buffer); > + goto Enomem; > + }
Btw, with single_open(), how do you ever get more than one call to ->show()? Shouldn't single_next() prevent that?
Joel
--
Life's Little Instruction Book #451
"Don't be afraid to say, 'I'm sorry.'"
Joel Becker Principal Software Developer Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |