Messages in this thread | | | Subject | Re: [PATCH 2.6.19-rc1] radeonfb: check return value of sysfs_create_bin_file | From | Benjamin Herrenschmidt <> | Date | Thu, 12 Oct 2006 10:07:26 +1000 |
| |
On Thu, 2006-10-12 at 01:53 +0200, Luca Tettamanti wrote: > sysfs_create_bin_file() is marked as warn_unused_result but we don't > actually check the return value. > Error is not fatal, the driver can operate fine without the files so > just print a notice on failure.
I find this whole business of must check return value for sysfs files to be gratuitous bloat. There are many cases (like this one) where we don't really care and a printk will just increase the kernel size for no good reason.
Maybe we can have a macro we can use to silence the warning when we don't care about the result ? Can gcc do that ?
Ben.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |