Messages in this thread Patch in this message | | | Date | Wed, 11 Oct 2006 14:08:20 -0700 | From | Greg KH <> | Subject | [patch 54/67] PKT_SCHED: cls_basic: Use unsigned int when generating handle |
| |
-stable review patch. If anyone has any objections, please let us know.
------------------ From: David Miller <davem@davemloft.net>
gcc-4.1 and later take advantage of the fact that in the C language certain types of overflow/underflow are undefined, and this is completely legitimate.
Prevents filters from being added if the first generated handle already exists.
Signed-off-by: Kim Nordlund <kim.nordlund@nokia.com> Signed-off-by: Thomas Graf <tgraf@suug.ch> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- net/sched/cls_basic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.18.orig/net/sched/cls_basic.c +++ linux-2.6.18/net/sched/cls_basic.c @@ -194,7 +194,7 @@ static int basic_change(struct tcf_proto if (handle) f->handle = handle; else { - int i = 0x80000000; + unsigned int i = 0x80000000; do { if (++head->hgenerator == 0x7FFFFFFF) head->hgenerator = 1; -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |