Messages in this thread | | | Date | Wed, 11 Oct 2006 16:17:33 -0400 | From | "Dmitry Torokhov" <> | Subject | Re: misused local_irq_disable() in analog.c? |
| |
On 10/11/06, Alexey Dobriyan <adobriyan@gmail.com> wrote: > Dmitry, take a look at analog_cooked_read(): > > do-while loop there contains local_irq_disable()/local_irq_restore(flags); > which aren't complement. > > Should it be > > local_irq_save(flags); > this = gameport_read(gameport) & port->mask; > GET_TIME(now); > local_irq_restore(flags); > > ?
Yep, I think so. Patch?
-- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |