lkml.org 
[lkml]   [2006]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2.6.19-rc1-mm1] Export jiffies_to_timespec()
    On Wed, 11 Oct 2006 17:16:28 +0100
    Christoph Hellwig <hch@infradead.org> wrote:

    > On Tue, Oct 10, 2006 at 05:36:54PM -0700, Jeremy Fitzhardinge wrote:
    > > Export jiffies_to_timespec; previously modules used the inlined header
    > > version.
    >
    > NACK, drivers shouldn know about these timekeeping details and no
    > in-tree driver uses it (fortunately)

    Disagree.

    a) `jiffies' and `timepsec' are hardly "details". They are basic
    kernel-wide concepts. timespecs are even known to userspace. Exporting
    a helper function which converts from one to the other is perfectly
    reasonable.

    b) jiffies_to_timespec() was previously available to modules. We
    changed that without notice and we changed it *by accident*. There was
    no intention to withdraw jiffies_to_timespec() from the
    available-to-modules API.


    If we really wanted to withdraw jiffies_to_timespec() then we'd mark it
    __deprecated_for_modules for a while, then withdraw it. But there's no
    earthly reason why we'd want to withdraw it: the export makes sense.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-10-11 20:21    [W:0.031 / U:0.276 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site