Messages in this thread | | | Subject | Re: [2.6 patch] drivers/scsi/dpt_i2o.c: remove dead code | From | Alan Cox <> | Date | Wed, 11 Oct 2006 15:51:40 +0100 |
| |
Ar Llu, 2006-10-09 am 01:16 +0200, ysgrifennodd Adrian Bunk: > The Coverity checker spotted this dead code introduced by > commit a07f353701acae77e023f6270e8af353b37af7c4. > > Signed-off-by: Adrian Bunk <bunk@stusta.de>
Semi-NAK
Its not dead jim, its in the wrong location
> while ((pDev = pci_get_device( PCI_DPT_VENDOR_ID, PCI_ANY_ID, pDev))) { > if(pDev->device == PCI_DPT_DEVICE_ID || > pDev->device == PCI_DPT_RAPTOR_DEVICE_ID){ > if(adpt_install_hba(sht, pDev) ){ > PERROR("Could not Init an I2O RAID device\n"); > PERROR("Will not try to detect others.\n");
------------------------> pci_dev_put()
is needed there instead I think.
Been away so just catching up
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |