Messages in this thread Patch in this message | | | Date | Tue, 10 Oct 2006 19:05:19 +0200 (CEST) | From | Jiri Kosina <> | Subject | Re: 2.6.19-rc1-mm1 -- WARNING: "toshoboe_invalid_dev" [drivers/net/irda/donauboe.ko] undefined! |
| |
On Tue, 10 Oct 2006, Miles Lane wrote:
> This stops the "make modules_install" process.
This is not only in -mm, but also in Linus' git tree. I just sent the patch below to Jeff (who is the author of the commit that broke it), which I believe might be correct:
[PATCH] fix reference to removed toshoboe_invalid_dev() in drivers/net/irda/donauboe.c
commit c31f28e778ab299a5035ea2bda64f245b8915d7c (which currently is in mainline) broke drivers/net/irda/donauboe.c, as it removes toshoboe_invalid_dev(), but this is called from toshoboe_interrupt() (your patch removed reference to it only from toshoboe_probeinterrupt().
Signed-off-by: Jiri Kosina <jikos@jikos.cz>
diff --git a/drivers/net/irda/donauboe.c b/drivers/net/irda/donauboe.c index 636d063..14cc217 100644 --- a/drivers/net/irda/donauboe.c +++ b/drivers/net/irda/donauboe.c @@ -1158,9 +1158,6 @@ toshoboe_interrupt (int irq, void *dev_i __u8 irqstat; struct sk_buff *skb = NULL; - if (self == NULL && toshoboe_invalid_dev(irq)) - return IRQ_NONE; - irqstat = INB (OBOE_ISR); /* was it us */ -- Jiri Kosina - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |