lkml.org 
[lkml]   [2006]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 0/4] Series to allow a "const" file_operations struct
    Eric Dumazet <dada1@cosmosbay.com> wrote:
    >
    > Arjan van de Ven a écrit :
    > > On Fri, 2006-01-06 at 22:45 +0100, Arjan van de Ven wrote:
    > >> Hi,
    > >>
    > >> this series allows drivers to have "const" file_operations, by making
    > >> the f_ops field in the inode const. This has another benefit, there have
    > >
    > > ok there was a sentence missing here. The first benefit is that this
    > > moves these hot datastructures to the rodata section, which means they
    > > won't accidentally be doing false cacheline sharing.
    > >
    >
    > Definitly a good thing I agree.
    >
    > But your patches miss to really declare all 'struct file_operations' as const,
    > dont they ?
    >
    >
    > On my x86_64 machine, I managed to reduce by 10% .data section by moving all
    > file_operations, but also 'address_space_operations', 'inode_operations,
    > super_operations, dentry_operations, seq_operations, ... to rodata section.
    >
    > size vmlinux*
    > text data bss dec hex filename
    > 2476156 522236 244868 3243260 317cfc vmlinux
    > 2588685 571348 246692 3406725 33fb85 vmlinux.old
    >

    Confused. Why should this result in an aggregate reduction in vmlinux size?
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-01-07 01:31    [W:0.027 / U:92.956 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site