Messages in this thread | | | Date | Fri, 6 Jan 2006 16:36:52 -0600 | From | Matt Domsch <> | Subject | Re: [PATCH 2.6.15] ia64: use i386 dmi_scan.c |
| |
On Fri, Jan 06, 2006 at 11:03:17AM -0800, Tolentino, Matthew E wrote: > Matt Domsch <> wrote: > > Enable DMI table parsing on ia64. > ... > > +#ifndef CONFIG_EFI > > +void __init dmi_scan_machine(void) > > +{ > > char __iomem *p, *q; > > + int rc; > > Hi Matt, > > You could potentially consolidate the two dmi_scan_machine functions > and lose the ifdef (and duplication) by checking efi_enabled instead. > 'efi_enabled' is already ifdef'd in the EFI header (defined to 1 for > ia64) specifically for this situation.
Good idea, patch to follow.
-- Matt Domsch Software Architect Dell Linux Solutions linux.dell.com & www.dell.com/linux Linux on Dell mailing lists @ http://lists.us.dell.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |