lkml.org 
[lkml]   [2006]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] slab: Adds missing kmalloc() checks.

Adds two missing kmalloc() checks in kmem_cache_init(). Note that if the
allocation fails, there is nothing to do, so we panic(); and the __LINE__
is used because is good to know which allocation has failed.

Signed-off-by: Luiz Capitulino <lcapitulino@mandriva.com.br>

mm/slab.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/mm/slab.c b/mm/slab.c
index e5ec26e..3f23ad2 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -1115,6 +1115,8 @@ void __init kmem_cache_init(void)
void * ptr;

ptr = kmalloc(sizeof(struct arraycache_init), GFP_KERNEL);
+ if (!ptr)
+ panic("%s at %d: Could not allocate memory.\n", __FUNCTION__, __LINE__);

local_irq_disable();
BUG_ON(ac_data(&cache_cache) != &initarray_cache.cache);
@@ -1124,6 +1126,8 @@ void __init kmem_cache_init(void)
local_irq_enable();

ptr = kmalloc(sizeof(struct arraycache_init), GFP_KERNEL);
+ if (!ptr)
+ panic("%s at %d: Could not allocate memory.\n", __FUNCTION__, __LINE__);

local_irq_disable();
BUG_ON(ac_data(malloc_sizes[INDEX_AC].cs_cachep)

--
Luiz Fernando N. Capitulino
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-01-06 16:22    [W:0.050 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site