lkml.org 
[lkml]   [2006]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [DRIVER CORE] platform_get_irq*(): return NO_IRQ on error
    On Thu, Jan 05, 2006 at 06:03:10PM +0000, David Vrabel wrote:
    > Greg KH wrote:
    > > On Thu, Jan 05, 2006 at 05:11:42PM +0000, David Vrabel wrote:
    > >
    > >>platform_get_irq*() cannot return 0 on error as 0 is a valid IRQ on some
    > >>platforms, return NO_IRQ (-1) instead.
    > >>
    > >>Signed-off-by: David Vrabel <dvrabel@arcom.com>
    > >>
    > >>--- linux-2.6-working.orig/drivers/base/platform.c 2006-01-05 16:49:23.000000000 +0000
    > >>+++ linux-2.6-working/drivers/base/platform.c 2006-01-05 17:10:18.000000000 +0000
    > >>@@ -59,7 +59,7 @@
    > >> {
    > >> struct resource *r = platform_get_resource(dev, IORESOURCE_IRQ, num);
    > >>
    > >>- return r ? r->start : 0;
    > >>+ return r ? r->start : NO_IRQ;
    > >
    > >
    > > No, I think the whole NO_IRQ stuff has been given up on, see the lkml
    > > archives for details.
    >
    > Now that you mention it I remember that thread[1].
    >
    > How about returning -ENXIO (or similar) then?

    That would be fine as long as you fix up all callers to not pass that
    value to request_irq() :)

    thanks,

    greg k-h
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-01-05 19:10    [W:0.024 / U:0.608 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site