Messages in this thread | | | Date | Thu, 05 Jan 2006 09:30:23 -0500 | From | Ben Collins <> | Subject | Re: [PATCH] fix workqueue oops during cpu offline |
| |
On Thu, 2006-01-05 at 17:03 +1100, Benjamin Herrenschmidt wrote: > On Thu, 2006-01-05 at 15:58 +1000, Nigel Cunningham wrote: > > Hi. > > > > On Thursday 05 January 2006 14:58, Nathan Lynch wrote: > > > With 2.6.15, powerpc systems oops when cpu 0 is offlined. This is a > > > regression from 2.6.14, caused by commit id > > > bce61dd49d6ba7799be2de17c772e4c701558f14 ("Fix hardcoded cpu=0 in > > > workqueue for per_cpu_ptr() calls"). > > > > So it's valid on ppc for cpu 0 to be taken offline? IIRC, trying that on my P4 > > a while back did nothing. I think you'll find other places that assume that > > cpu 0 is always up (swsusp? ... I should check suspend2). > > It's bogus, cpu0 can be put offline.
Not only that, but on some systems it may never even exist. Which was the whole reason for my problem in the first place with the workqueue code.
I haven't tested it, but the patch would appear to work for me. Since sparc64 doesn't support CPU hotplug, the cpu_possible_map is just a copy of cpu_present_map. I'll merge it into my tree and give it a run on the ultra3k.
-- Ben Collins <ben.collins@ubuntu.com> Developer Ubuntu Linux
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |